Aiven-Open / Aiven-Open/klaw

bug(coral/core): The `search` param in some endpoints matches on data which is not displayed

Open
#1,821 0 comments 1 reaction 0 assignees View on GitHub
Backend bug Frontend
Dominant language
Java
Stars
195
Forks
77
Avg merge
8d 9h
Merged PRs (30d)
1

Description

# What happened?

In this example, the data displayed in the table after getting the response from `/environments/kafka?pageNo=1&searchEnvParam=PR` seems incorrect, as the first row doesn't seem to match the search term. However, it *does* seem to match data that is not displayed in the table:
Screenshot 2023-09-29 at 13 54 02

I haven't tested this throughly, so we need to ascertain that it is really what is happening here. (@aindriu-aiven probably can help)

# What did you expect to happen?

The table only displays rows if the data which is *rendered* matches the search term.

This is a bit of a sticky problem. We can either:
- render all data that is susceptible to be matched in the table. Problem: this might overload the table with data which is not relevant to the current page
- do an additional front-end filter on the data returned by the calls with a `search` param to ensure that only the matching data that is actually rendered is passed to the table component. Problem: bulky, uncomfortable prone to further bugs (if our filtering accidentally filters out something that should not be). And needs to be fixed in many places.
- another solution I can't think of immediately

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.