Aiven-Open / Aiven-Open/karapace

Call to undefined method in `SchemaRegistryClient.post_new_schema()`

未关闭
#639 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
634
派生
110
平均合并
4 天 7 小时
30 天内合并 PR
4

描述

### What happened?

Discovered when working on static type checking coverage.

On this line there's a call to `references.json()` where `references: Reference`, however `Reference` has no `.json()` method.

https://github.com/aiven/karapace/blob/42b14c71543b878c42c11025ab266122d61550d3/karapace/serialization.py#L92

I tried adding `raise NotImplementedError` on that line, and confirmed that there is no test coverage there. Presumably, a case should be added to `tests/integration/test_client_protobuf.py`.

### What did you expect to happen?

- Test suite should be failing.
- Correct method should be called.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。