Airspace-Encounter-Models / Airspace-Encounter-Models/em-model-manned-bayes

Altitude and speed bounds throw errors on default behavior with cor_v2p1

Ouverte
#45 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement help wanted
Langage dominant
MATLAB
Étoiles
22
Forks
9
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Description
When running `sample2track.m` with a RADES correlated model (ex. `cor_v2p1.txt`), getters for altitude and speed bounds don't work properly. For altitude, getting `min_speed` and `max_alt` in lines 104-105 of `sample2.track.m` throws an exception because min/max alt bounds do not exist in `cor_v2p1.txt` at boundary index 2, the index of variable `L`. For speed, the default label (set in line 28) is `'v'`, which is not a valid label in the correlated model because there are only `'v_1','v_2'`.

### Reproducibility
`[isGood, ~] = sample2track(parameters_filename, initial_output_filename, transition_output_filename, ...
'out_dir_parent', out_dir_parent)
with valid inputs, and `parameters_filename = 'cor_v2p1.txt'`, should reproduce both issues.

### Expectation
I resolved this issue by simply adding altitude bounds back into `cor_v2p1.txt` consistent with the model report. For the speed bounds, I explicitly passed in `'label_initial_speed', 'v_1'` into the function call, but I think this should be fixed in such a way that the function does not break on default functionality (i.e. either this should be a required argument or it should know to use 'v' or 'v_1' depending on the model).

### Environment
Debian 10, MATLAB R2021a

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.