AhsanAyaz / AhsanAyaz/ngx-device-detector

`orientation` is not reliably set

Abierto
#280 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
559
Forks
106
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Describe the bug**
The value for `orientation` is not reliably set. When testing a page with Browserstack for example, the orientation remains as `portrait` regardless of the actual device orientation.

**To Reproduce**
Steps to reproduce the behavior:
1. Add an event listener to the window `resize` event
2. Read and `console.log` the current value for `orienation`
3. Push the branch to test with Browserstack (or use Browserstack Local) for example
4. Open developer tools
5. The log will always say `portrait` regardless of the actual device orientation

**Expected behavior**
The value for `orientation` should reliably be set in correspondence with the actual device orientation.

**Screenshots**
![Screenshot 2023-06-15 at 16 40 46](https://github.com/KoderLabs/ngx-device-detector/assets/7312890/be148662-33e5-45f3-aa7a-135159313359)
![Screenshot 2023-06-15 at 16 41 02](https://github.com/KoderLabs/ngx-device-detector/assets/7312890/7cfe9acc-5583-48b3-bf67-3027c82564b8)
![Screenshot 2023-06-15 at 16 41 16](https://github.com/KoderLabs/ngx-device-detector/assets/7312890/1fb23515-f54b-47ac-8c0f-d7e20c62d6a3)

**Desktop (please complete the following information):**
-> handheld devices only

**Smartphone (please complete the following information):**
- Device: iPhone14 Pro
- OS: iOS 16.3
- Browser: Safari

**Additional context**
Add any other context about the problem here.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.