AdoptOpenJDK / AdoptOpenJDK/jlink.online

Cross targeting fails on Windows if target runtime contains symlinks

Aberta
#22 1 comentário 0 reações 1 responsável Reivindicada por @cilki Ver no GitHub
bug
Linguagem predominante
Go
Estrelas
51
Forks
7
Merge médio
3min
PRs com merge (30d)
2

Descrição

https://github.com/AdoptOpenJDK/jlink.online/blob/e0b932e90aef03350e1a757b62d5b6c6c64fe530/jlink_test.go#L106 fails on Windows. The reason is that the tar.gz for Linux contains symlinks. Those cause `archiver.Unarchive()` to fail (as well as 7zip, so not archiver's fault) with the following error:

```
reading file in tar archive: C:\Users\andreas\AppData\Local\Temp\runtime_cache\OpenJDK11U-jdk_x64_linux_hotspot_11.0.8_10\jdk-11.0.8+10\legal\jdk.localedata\ASSEMBLY_EXCEPTION: making symbolic link for: symlink ..\java.base\ASSEMBLY_EXCEPTION C:\Users\andreas\AppData\Local\Temp\runtime_cache\OpenJDK11U-jdk_x64_linux_hotspot_11.0.8_10\jdk-11.0.8+10\legal\jdk.localedata\ASSEMBLY_EXCEPTION: A required privilege is not held by the client.
```

I'm not sure how to proceed here. https://pkg.go.dev/github.com/mholt/archiver/v3#TarGz has no option to ignore symlinks or continue on error. We could ignore the return code and continue no matter what, but I don't think this is desirable.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.