AdoptOpenJDK / AdoptOpenJDK/IcedTea-Web

LockableFiles may be erroneously marked as "stale" on systems with filesystem tunneling enabled

未关闭
#916 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Java
星标
268
派生
96
PR 合并指标
30 天内没有已合并 PR

描述

IcedTea-Web version: 2.0.0-alpha23
OpenWebStart version: 1.5.2
JDK: Azul 1.8.0u322
OS: Windows 10

When determining whether a LockableFile is stale, [the file's creationtime is used](https://github.com/AdoptOpenJDK/IcedTea-Web/blob/70baee55ab8b89bd18aec1f3ff5c00b21c3c977b/common/src/main/java/net/adoptopenjdk/icedteaweb/lockingfile/LockableFile.java#L363C74-L363C74). This causes some issues in Windows when [filesystem tunneling](https://web.archive.org/web/20160410012540/https://support.microsoft.com/en-us/kb/172190) is enabled, as the creation time is unlikely to change for commonly-used lock files, such as `recently_used.cache.lock`.

We have noticed this when running multiple instances of OpenWebStart, where both processes are populating the cache at the same time. This results in a state where both processes claim ownership over the cache lock.

Attached are log files from a modified OpenWebStart jar. These logs only include log messages from LockableFile for clarity and security. I added a log message to determine what the creation time of the file and the current time were when a stale lock file was detected. Note that each time the stale lock is detected, the creation time of the file remains the same, and matches the time the file is first created in the first line of 2023-07-04_15_03_33.38-ows-stage1.log.

Two low-impact solutions to this issue:

- When creating the lockFile, explicitly set the creation time with `BasicFileAttributeView.setTimes()`
- Use `BasicFileAttributes.lastModifiedTime()` to determine whether a LockableFile is stale instead of creationTime.

[2023-07-04_15_03_33.38-ows-stage1.log](https://github.com/AdoptOpenJDK/IcedTea-Web/files/11952677/2023-07-04_15_03_33.38-ows-stage1.log)
[2023-07-04_15_03_33.38-ows-stage2.log](https://github.com/AdoptOpenJDK/IcedTea-Web/files/11952678/2023-07-04_15_03_33.38-ows-stage2.log)
[2023-07-04_15_03_33.616-ows-stage1.log](https://github.com/AdoptOpenJDK/IcedTea-Web/files/11952679/2023-07-04_15_03_33.616-ows-stage1.log)
[2023-07-04_15_03_33.616-ows-stage2.log](https://github.com/AdoptOpenJDK/IcedTea-Web/files/11952680/2023-07-04_15_03_33.616-ows-stage2.log)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。