AdoptOpenJDK / AdoptOpenJDK/IcedTea-Web

DeploymentRuleset: add matching logic for rules

Open
#830 0 comments 0 reactions 0 assignees View on GitHub
deployment ruleset
Dominant language
Java
Stars
268
Forks
96
PR merge metrics
No merged PRs in 30d

Description

Implement matching of rules according to https://docs.oracle.com/javase/10/deploy/deployment-rule-set.htm#GUID-413F29CF-81B5-4154-9C52-22D993819C2B

In the class `net.adoptopenjdk.icedteaweb.deploymentrules.Rule` there is a TODO in the method `matches`.

Please add the missing implementation and also include tests.

Inspiration can be drawn from the class `ParsedWhitelistEntry`

Decide how to react if a rule has any of the following elements or attributes set:
* title
* certificate
* checksum
* jnlp-checksum

Contributor guide

Open the contributing guide

Research direction

Read the TODO in net.adoptopenjdk.icedteaweb.deploymentrules.Rule.matches and compare its expected behavior with the Java deployment rule set specification. Use ParsedWhitelistEntry as the stated inspiration, then add tests covering matching and rules containing title, certificate, checksum, or jnlp-checksum; done means the missing logic is implemented and the tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.