AdguardTeam / AdguardTeam/gomitmproxy

Feat request: Please allow us to have access to transport config

Aperta
#24 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
Go
Stelle
344
Fork
71
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

`gomitmproxy.NewProxy` starts out as follows:

```go

// NewProxy creates a new instance of the Proxy
func NewProxy(config Config) *Proxy {
proxy := &Proxy{
Config: config,
transport: &http.Transport{
// This forces http.Transport to not upgrade requests to HTTP/2
// TODO: Remove when HTTP/2 can be supported
TLSNextProto: make(map[string]func(string, *tls.Conn) http.RoundTripper),
Proxy: http.ProxyFromEnvironment,
...
```

The `Proxy: http.ProxyFromEnvironment` is what affects me specifically. I am using an upstream proxy, and having to `os.Setenv...` to make it work is very inelegant:

```go
os.Setenv("ALL_PROXY", upstreamProxy)
os.Setenv("HTTP_PROXY", upstreamProxy)
os.Setenv("HTTPS_PROXY", upstreamProxy)
fmt.Println("Upstream Proxy =", upstreamProxy)
```

Being able to pass this in, perhaps via the `Config` would be amazing. I would be happy to make a PR, please suggest if can be added to `Config` (maybe simple/non-breaking) or should be done some other way.

Thank you.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.