AdguardTeam / AdguardTeam/dnsproxy

The strange form of `GOPROXY` variable in Makefile.

Open
#408 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
3.3k
Forks
343
PR merge metrics
No merged PRs in 30d

Description

Is the following usage of `GOPROXY` correct?
https://github.com/AdguardTeam/dnsproxy/blob/791906ea48e8bb350a79b456ceeac69915583df0/Makefile#L26

Shouldn't it be written as follows?

```
GOPROXY = https://proxy.golang.org,direct
```

See https://github.com/AdguardTeam/dnsproxy/issues/407#issuecomment-2266364255 for the related discussion.

Regards,
Zhao

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.