AdguardTeam / AdguardTeam/dnsproxy

SERVFAIL handling with --all-servers

Ouverte
#354 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Go
Étoiles
3.3k
Forks
343
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Currently with `--all-servers` enabled, it seems like the fastest response is forwarded, even if that happens to be a `SERVFAIL`, which is pretty bad for some use cases. A `SERVFAIL` can indicate network problems, e.g. some DNS servers/proxies answer very quickly with `SERVFAIL`, when their own upstream is dead (which I guess is correct and reasonable), in this case `--all-servers` makes things even worse than using just a single server, because now if any upstream is dead, we're always failing.

I suggest changing `SERVFAIL` handling to by default only forward it, if all upstream servers happen to respond with `SERVFAIL`.

In case someone brings DNSSEC as argument, maybe `SERVFAIL`s can optionally be forwarded immediately, if coming with an appropriate EDE error code (RFC 8914).

(The `SERVFAIL` handling in fallback mode might be related: https://github.com/AdguardTeam/dnsproxy/issues/257)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.