AdguardTeam / AdguardTeam/dnsproxy

*testing.T.Fatalf() is called in sendTestMessageAsync() from mutiple goroutines

Open
#112 0 comments 1 reaction 1 assignee Claimed by @ainar-g View on GitHub
good first issue
Dominant language
Go
Stars
3.3k
Forks
343
PR merge metrics
No merged PRs in 30d

Description

https://github.com/AdguardTeam/dnsproxy/blob/2f7a50c830677fd6fed48a071a5f8f4ff563c1a8/proxy/proxy_test.go#L751

https://github.com/AdguardTeam/dnsproxy/blob/2f7a50c830677fd6fed48a071a5f8f4ff563c1a8/proxy/proxy_test.go#L734

The golang comment says that `Fatalf()` `must be called only from the goroutine running the Test function.`

https://github.com/golang/go/blob/926994fd7cf65b2703552686965fb05569699897/src/testing/testing.go#L659

```
// T is a type passed to Test functions to manage test state and support formatted test logs.
//
// A test ends when its Test function returns or calls any of the methods
// FailNow, Fatal, Fatalf, SkipNow, Skip, or Skipf. Those methods, as well as
// the Parallel method, must be called only from the goroutine running the
// Test function.
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.