AdguardTeam / AdguardTeam/Scriptlets

Improve 'trusted-replace-argument' — add new constant values

Ouverte
#562 0 commentaires 0 réactions 1 personne assignée Réclamée par @maximtop Voir sur GitHub
Priority: P4
Langage dominant
JavaScript
Étoiles
195
Forks
33
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Related to https://github.com/AdguardTeam/AdguardFilters/issues/232621

Steps to reproduce:
1. Add to user rules:
```adblock
example.org#%#//scriptlet('trusted-replace-argument', 'Promise', '0', 'noopPromiseResolve', 'isDetected')
```
2. Navigate to https://example.org/
3. In browser console run:
```js
(async () => {
const checkAdblock = () => {
console.log('Checking for adblock...');
return new Promise((resolve) => {
// Set to true by default for demonstration purposes
const isDetected = true;
resolve(isDetected);
});
};

const init = async () => {
const [result] = await Promise.all([
checkAdblock(),
]);

if (result) {
console.log('Adblock detected');
return;
}

console.log('Load content');
}

await init();
console.log('Script loaded');
})();
```

With current solution only `Checking for adblock...` is printed in console (the same for`noopCallbackFunc`, `noopFunc`, `falseFunc`).
Expected is:
```
Checking for adblock...
Load content
Script loaded
```
So, I think we could add functions which return callback with `false`/`true`, something like:
```js
const falseCallbackFunc = (callback) => { callback(false); };
const trueCallbackFunc = (callback) => { callback(true); };
```


And/Or we could add support for `valueWrapper` similar like in https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-scriptlets.md#set-constant

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.