AdguardTeam / AdguardTeam/Scriptlets

Improve 'googlesyndication-adsbygoogle' — fails to create iframes when there's no '.adsbygoogle'

未關閉
#525 3 則留言 1 個 reaction 已指派 1 人 已被 @maximtop 認領 在 GitHub 檢視
enhancement Priority: P4 Waiting for data
主要語言
JavaScript
星號
195
分支
33
PR 合併指標
30 天內沒有已合併 PR

描述

It seems the current `googlesyndication-adsbygoogle` fails to create `iframe#aswift_1` etc. if `.adsbygoogle` does not exist when its executed. This is causing these filters in Base
```
pvpoke-re.com#%#//scriptlet('trusted-create-element', '.adsbygoogle:has(> #aswift_1)', 'div', 'id="aswift_1_host" style="height: 280px; width: 780px;"')
pvpoke-re.com#%#//scriptlet('trusted-create-element', '.adsbygoogle:has(> #aswift_2)', 'div', 'id="aswift_2_host" style="height: 280px; width: 396px;"')
```

to occasionally fail on the initial load, as they depend on existence of the iframes.

Expected fix:
the redirect should handle the case where `.adsbygoogle` elements do not yet exist at script execution time, likely by observing DOM mutations (via `MutationObserver`) and creating the required iframes (`#aswift_1`, etc.) when `.adsbygoogle` elements are inserted.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。