AdguardTeam / AdguardTeam/Scriptlets

Improve 'set-constant' — support generating a constructor

Open
#365 2 comments 0 reactions 1 assignee Claimed by @maximtop View on GitHub
enhancement Priority: P4
Dominant language
JavaScript
Stars
195
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Generating a constructor in `set-constant` scriptlet means that a filters list maintainer can make a fake class with custom methods and properties.

For example, a filters list maintainer can use it as the following filters:
```adblock
example.com#%#//scriptlet('set-constant', 'human', 'constructor')
example.com#%#//scriptlet('set-constant', 'human.prototype.sleep', 'noopFunc')
example.com#%#//scriptlet('set-constant', 'human.prototype.IsSleeping', 'false')
example.com#%#//scriptlet('set-constant', 'human.prototype.IsSleepingFunc', 'falseFunc')
```
The above filters can be converted to the following Typescript:
```typescript
class human {
constructor() {
this.IsSleeping = false
}

sleep() {
// noopFunc
}

IsSleepingFunc() {
return false
}
}
```

The generating a constructor in set-constant scriptlet can help to resolve a advertisement/tracking-related class in a normal `` element or javascript file without allowing the advertisement/tracking-related another javascript file. (E.g., https://github.com/AdguardTeam/AdguardFilters/issues/161389)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.