AdguardTeam / AdguardTeam/HostlistCompiler

Compress Not Working--Case Sensitivity.

Ouverte
#59 0 commentaires 0 réactions 1 personne assignée Réclamée par @maximtop Voir sur GitHub
Priority: P4
Langage dominant
JavaScript
Étoiles
232
Forks
30
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I have my lists set to compress twice: once for each individual list so that my exclusions will work properly, and once at the end to compress fully the multiple lists that I use in order to remove redundant entries. The problem--or maybe it's a feature I overlooked--is that if a domain has an uppercase letter, HostlistCompiler doesn't acknowledge the redundant entries as redundant and leaves them in the list. For example, I have a list with the following entries after being compressed:
||2o7.net^
||ziffdavisetech.112.2O7.net^
||msstonojstemp.112.2O7.net^

Not sure why the second and third entries have a random capital O but I remember seeing this same thing occur in the Phishing Army list on Adguard DNS. There were two entries with the same name, but because one of them was capitalized, both entries were left in the list. There were a lot more 2o7.net entries but the compress transformation removed them, since ||2o7.net^ is in the list. Is it possible that these sites are supposed to be capitalized? I always thought that websites weren't case sensitive. Phishing Army has since fixed the entries in their list, so it doesn't happen anymore.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.