AdguardTeam / AdguardTeam/FiltersCompiler

Transform rules for Samsung Browser compatibility

Open
#2 1 comment 0 reactions 0 assignees View on GitHub
Priority: P3
Dominant language
JavaScript
Stars
64
Forks
11
PR merge metrics
No merged PRs in 30d

Description

@ameshkov commented on [Mon Aug 21 2017](https://github.com/AdguardTeam/AdguardFilters/issues/6385)

The problem is that Samsung cannot handle `^` symbol when it means the end of URL:

For instance:
`||google-analytics.com/analytics.js^` won't match `https://google-analytics.com/analytics.js`

To fix this issue we should add a duplicate rule with `|` instead of `^` for every rule matching this regexp:
`^(@@)?\|\|.+?/.+?\^(\$.*)?$`

For instance, this rule:
```
`||google-analytics.com/analytics.js^$third-party`
```

Should be replaced with two:
```
`||google-analytics.com/analytics.js^$third-party`
`||google-analytics.com/analytics.js|$third-party`
```

**It should be done for Content Blocker filters only**

---

@Mizzick commented on [Wed Oct 18 2017](https://github.com/AdguardTeam/AdguardFilters/issues/6385#issuecomment-337695856)

>It should be done for Content Blocker filters only

But what is Content FIlter? How to define it?

---

@ameshkov commented on [Sun Oct 22 2017](https://github.com/AdguardTeam/AdguardFilters/issues/6385#issuecomment-338481779)

> But what is Content FIlter? How to define it?

I mean rules for iOS, Safari, and for Android Content Blocker

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.