AdguardTeam / AdguardTeam/FiltersCompiler

Figured I should give a headsup about an unusual aspect of `$all` in uBlock Origin

Open
#158 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
64
Forks
11
PR merge metrics
No merged PRs in 30d

Description

This is a bit of a fringe scenario, although it's been tested out with success in Dandelion Sprout's Annoyances List, but it could become useful for you guys at some point in the future:

When an entry uses `$all`, uBlock Origin counts that entry as 5 entry points in their dashboard settings, one for each of [no $ value] + `$popup` + `$document` + `$inline-script` + `$inline-font`.

However, it turns out that this can be reduced to 3 points by changing `$all` to `$all,~inline-script,~inline-font`, especially since https://github.com/AdguardTeam/FiltersRegistry/blob/master/filters/exclusions.txt implies that AdGuard Filters was never designed with `$inline-script` and `$inline-font` in mind anyway.

For example, AdGuard Base Filter's uBO list version is currently shown in uBO as having 65,694 entries ±500. Had all its 235 `$all` entries been converted to `$all,~inline-script,~inline-font`, then the number would've gone down to circa 65,224 ±500. Though this would not be a big enough difference to make that list seem any more compact, and that it'd actually take up *more* filespace, it'd become a big deal if any of your lists' amount of `$all` entries entered the 4-digits.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.