AdguardTeam / AdguardTeam/ExtendedCss

Add ability to remove 'text' node

Aperta
#165 2 commenti 0 reazioni 1 assegnatario Rivendicata da @maximtop Vedi su GitHub
feature request Priority: P2 Version: ExtendedCss v2.2
Lingua principale
TypeScript
Stelle
71
Fork
11
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Related to - https://github.com/AdguardTeam/ExtendedCss/issues/106
Another issue when it could be useful - https://github.com/AdguardTeam/AdguardFilters/issues/146786
https://github.com/AdguardTeam/AdguardFilters/pull/146872


Test page - https://jsfiddle.net/yehz25L4/
Code:

```html





Document


Advertisement

Test


1234


qwerty



```

Rule which should remove text `Advertisement`:
```adblock
fiddle.jshell.net#$?#:xpath(//div[contains(@id,"test")]/text()[contains(.,'Advertisement')]) { remove: true; }
```

`ExtendedCss.query` which should match element:
```js
ExtendedCss.query(`:xpath(//div[contains(@id,"test")]/text()[contains(.,'Advertisement')])`)
```

I might be wrong, but I guess that it doesn't work currently, because `isHtmlElement`
https://github.com/AdguardTeam/ExtendedCss/blob/7d2957ffbf92c7f082a861276024e733fd0a8477/src/common/utils/nodes.ts#L87-L89
returns `false` for `text` node and probably due to this, element is not matched.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.