AdguardTeam / AdguardTeam/CoreLibs

Apply $removeparam rules to URLs updated via history.pushState / history.replaceState

Aperta
#2,071 0 commenti 1 reazione 1 assegnatario Rivendicata da @sfionov Vedi su GitHub
Feature request Priority: P4 Version: CoreLibs v1.24
Lingua principale
Nessun dato sulla lingua
Stelle
52
Fork
10
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Issue Details

`$removeparam` is currently applied to real network requests, but not to URLs changed client-side via `history.pushState` or `history.replaceState` in single-page applications. Because of this, on sites like VK Video and Yandex Market, tracking parameters may remain visible in the address bar after in-app navigation without a full page reload. The same parameters also remain in the URL when copied from the address bar. This leads to inconsistent behavior between regular navigations and SPA-driven URL updates. Reference: #2070

### Proposed solution

Extend `$removeparam` handling so that it is also applied when a page updates the current URL through `history.pushState` or `history.replaceState`, without requiring a real network request or full page reload. When a SPA writes a new URL to browser history, AdGuard should sanitize that URL using matching `$removeparam` rules before it is shown in the address bar and before it can be copied. The implementation should preserve normal SPA navigation behavior and be validated across supported products, including extensions, to ensure consistent behavior.

### Alternative solution

_No response_

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.