AdguardTeam / AdguardTeam/CoreLibs

Add support for CIDR in "$network"

Đang mở
#1,646 2 bình luận 0 reaction 0 người được giao Xem trên GitHub
Feature request needs tech clarification P4: Low Priority: P4
Ngôn ngữ chính
Không có dữ liệu ngôn ngữ
Star
52
Fork
10
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

I received a good tip on Slack that `propellerads` primarily rotate their domains within the CIDR range `139.45.192.0/18`, as seen with `https://securitytrails.com/list/ip/139.45.192.0%2f18`. So I initially opened up my *AdGuard for Windows* installation and tried to enter `139.45.192.0/18$network` into the "User Filters"... and saw that AdGuard refused that entry, claiming it was incorrectly formatted.

Thus I propose adding CIDR support in `$network` blocking rules.

The alternative would be for AdGuard Base to add entries against all 16,384 individual IP addresses, which I assume would be very impractical.

### Steps to reproduce

1. Go to Settings → Adblocker → User filter
2. Try to add `139.45.192.0/18$network` as a new entry.
3. See that the textbox receives red error edges and that AdGuard refuses to save the entry.

### Expected behavior

CIDR can be used in `$network` entries.

### Actual behavior

CIDR cannot be used in `$network` entries.

Screenshot:

![image](https://user-images.githubusercontent.com/22780683/89107104-fc052080-d42e-11ea-8b81-2a7c12ca1d74.png)

### Customer ID

Can't find within the AdGuard program.

### Your environment

* Environment name and version: AdGuard for Windows 7.4.2
* Operating system and version: Windows 10 May 2020 Update, build 19041.388

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.