Comment starting with ‘#’ counted as filter rule

Open

#1,746 opened on Apr 3, 2021 2 comments 0 reactions 0 assignees View on GitHub

Bug P4: Low Priority: P4 TechAudit Version: ADGuard v4.6 [Reserved]

Dominant language: Swift
Stars: 1.7k
Forks: 240
PR merge metrics: No merged PRs in 30d

Description

### Issue Details

- **AdGuard version:**
- v4.1.1 (668)
- **Device model and storage size:**
- iPhone 8 256gb
- **Operating system and version:**
- 14.4.2

### Expected Behavior

The comment should not be interpreted as a filter rule. The comment should also display below the filter title in the filter list.

### Actual Behavior

The comment was interpreted as a filter rule and included in the rule counter. The comment does not display below the filter title.

### Screenshots

Screenshots:

![The filter](https://user-images.githubusercontent.com/22475143/113489473-7db3bf00-9492-11eb-84dc-e53f151c3a47.jpeg)
_The filter_

![comment not displayed](https://user-images.githubusercontent.com/22475143/113489504-9fad4180-9492-11eb-8809-7e0ef7b65514.jpeg)
_The comment does not display below the title like it's supposed to_

![comment counted as rule](https://user-images.githubusercontent.com/22475143/113489489-8e643500-9492-11eb-8f57-ad536385ebae.jpeg)
_The comment is counted as a rule. There's only one rule but the app counts two._

### Additional Information

The app is set to the AdGuard DNS mode with the server as AdGuard DNS (QUIC).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Comment starting with ‘#’ counted as filter rule

Description

Contributor guide

Assessment

Get new issues in your inbox