AdguardTeam / AdguardTeam/AdguardForiOS

FR: Reduce the number of clicks required to block an element

Open
#1,611 0 comments 1 reaction 0 assignees View on GitHub
Enhancement Medium P3: Medium Priority: P4 TechAudit Version: ADGuard v4.6 [Reserved]
Dominant language
Swift
Stars
1.7k
Forks
240
PR merge metrics
No merged PRs in 30d

Description

@specter78 commented on [Mon Jul 13 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334)

Example: Popup of `element blocking` even after selecting `block an element on this page`

---

@specter78 commented on [Sun Jul 26 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-663959469)

@ameshkov Warning popup saying `content blocker is disabled` is very annoying and should be shown only **once** and not every time assistant is launched.

Even if the blockers are disabled, `user filters` list still works.

---

@ameshkov commented on [Thu Jul 30 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-666362549)

Hm, could you please show it on a screenshot? I don't understand what popup you are referring to

---

@specter78 commented on [Thu Jul 30 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-666382712)

> Hm, could you please show it on a screenshot? I don't understand what popup you are referring to

Screenshot

![popup](https://user-images.githubusercontent.com/40606342/88931918-0d1d2880-d29b-11ea-8a32-29f228a02722.jpg)

---

@zzebrum commented on [Thu Jul 30 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-666492484)

@specter78 user rules are working if at least one content blocker enabled. But yes, in this case, we should show the notification only if all content blockers disabled.

---

@specter78 commented on [Thu Jul 30 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-666500483)

> Even if the blockers are disabled, `user filters` list still works.

@zzebrum A little clarification - I have filters enabled in safari settings, but not within adguard app.

---

@zzebrum commented on [Thu Jul 30 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-666506377)

now, I'm a little confused :) in Safari settings you mean content blockers, right?

---

@specter78 commented on [Thu Jul 30 2020](https://github.com/AdguardTeam/AdguardAssistant/issues/334#issuecomment-666538518)

> in Safari settings you mean content blockers, right?

Yes. Sorry, my bad.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.