AdguardTeam / AdguardTeam/AdguardBrowserExtension

$all should have priority over rule with $popup

Aperta
#2,732 0 commenti 0 reazioni 1 assegnatario Rivendicata da @105th Vedi su GitHub
Bug Priority: P4
Lingua principale
TypeScript
Stelle
4.4k
Fork
449
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### AdGuard Extension version

4.3.29 beta

### Browser version

Chrome 122

### OS version

macOS 12.5

### What filters do you have enabled?

_No response_

### What Stealth Mode options do you have enabled?

_No response_

### Issue Details

In the current schema, a rule with `$all` has lower priority than a rule with `$popup`. This causes an issue in the `tswebextension` part, as seen here: https://github.com/AdguardTeam/tsurlfilter/blob/tswebextension-v1.0.16/packages/tswebextension/src/lib/mv2/background/request/request-blocking-api.ts#L115. When a rule with `$popup` is selected and the tab with the opened ad is not new—such as after clicking on a banner—we can neither cancel the request nor show our dummy blocking page, nor can we close the tab.

Therefore, in cases where an ad opens in the current tab, it leads to incorrect logic by allowing these requests to bypass the intended blocking mechanism.

### Expected Behavior

When opening ad in current tab - it should be blocked as well.

### Screenshots

Screenshot 1:

### Additional Information

_No response_

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.