AdguardTeam / AdguardTeam/AdGuardMiniForMac

Diagnosis and warning about invalid rules

オープン
#509 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る
Feature request Priority: P4
主要言語
Swift
スター
1.2k
フォーク
83
PR マージ指標
PR 指標を取得中

説明

Adguard 1.8.10
Safari 13.1.2 (13609.3.5.1.5)
MacOS 10.13.6 (17G14042)

### Problem Description

Bug #455 and bug #485 ("won't do" and "won't do") are both due to change in adguard parsing behaviour to change to silently reject "invalid" rules.

As a user, this is not a satisfactory resolution, as there appears to be no way to determine if a rule is synatically valid, aside from happening to notice that a rules does not appear to work after an adguard update (or after making a mistake editing a rule).

The user then has to performing tiresome trial and error on the user rules configuration file, first to find the offending rule, and second level of trial-and-error to attempt to guess the Adguard parser's precise criteria.

It's even harder to work out the problem when something that worked, perhaps accidentally, for years in adblock ublock etc suddenly stops working, because the rule "looks good" and nothing was edited.

"The rule is invalid, you shouldn't use pipe characters in the cosmetic rules." was news to me.

Note that I do have "Verbose logging" enabled.
I can still find nowhere where Adguard mentions that it is silently ignoring a rule that it determined to be syntatically invalid.

### Proposed Solution

Log information about invalid rules in some location that the user can find it, and notify user when rules have been ignored.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。