AdguardTeam / AdguardTeam/AdGuardMiniForMac

Can't apply element hiding rule to the element inside IFRAME

Aperta
#105 6 commenti 1 reazione 0 assegnatari Vedi su GitHub
Bug Priority: P3
Lingua principale
Swift
Stelle
1.2k
Fork
83
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

@Alex-302 commented on [Sat Sep 09 2017](https://github.com/AdguardTeam/AdguardBrowserExtension/issues/852)

Original issue
https://github.com/AdguardTeam/AdguardFilters/issues/6595#issuecomment-328218629

![image](http://imagizer.imageshack.com/img922/485/1lY9Wi.png)

Does not work: `t3n-de.cdn.ampproject.org##amp-iframe`
works: `google.de##amp-iframe`

---

@ameshkov commented on [Sun Sep 17 2017](https://github.com/AdguardTeam/AdguardBrowserExtension/issues/852#issuecomment-330051035)

The thing is that this is how it is supposed to work in Safari.

`if-domain`/`unless-domain` are checked against the window domain, frame domain is ignored.

We can fix this if we use `url-filter` instead of the `if-domain`, but it's not good from the performance point of view.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.