AdguardTeam / AdguardTeam/AdGuardMiniForMac

Can't apply element hiding rule to the element inside IFRAME

Open
#105 6 comments 1 reaction 0 assignees View on GitHub
Bug Priority: P3
Dominant language
Swift
Stars
1.2k
Forks
83
PR merge metrics
PR metrics pending

Description

@Alex-302 commented on [Sat Sep 09 2017](https://github.com/AdguardTeam/AdguardBrowserExtension/issues/852)

Original issue
https://github.com/AdguardTeam/AdguardFilters/issues/6595#issuecomment-328218629

![image](http://imagizer.imageshack.com/img922/485/1lY9Wi.png)

Does not work: `t3n-de.cdn.ampproject.org##amp-iframe`
works: `google.de##amp-iframe`

---

@ameshkov commented on [Sun Sep 17 2017](https://github.com/AdguardTeam/AdguardBrowserExtension/issues/852#issuecomment-330051035)

The thing is that this is how it is supposed to work in Safari.

`if-domain`/`unless-domain` are checked against the window domain, frame domain is ignored.

We can fix this if we use `url-filter` instead of the `if-domain`, but it's not good from the performance point of view.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.