AdguardTeam / AdguardTeam/AdGuardHome

Wildcard $dnsrewrite interfering with non-wildcard $dnsrewrite

Open
#5,347 13 comments 0 reactions 1 assignee Assigned to @ainar-g View on GitHub
enhancement P3: Medium
Dominant language
TypeScript
Stars
36.9k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

### Prerequisites

- [X] I have checked the [Wiki](https://github.com/AdguardTeam/AdGuardHome/wiki) and [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions) and found no answer

- [X] I have searched other issues and found no duplicates

- [X] I want to request a feature or enhancement and not ask a question

### Description

#### What problem are you trying to solve?
Given the following rewrite rules:
```
|*.services.home.lan|$dnstype=A,dnsrewrite=NOERROR;A;192.168.0.5
|unifi.services.home.lan|$dnstype=A,dnsrewrite=NOERROR;A;192.168.1.2
```
`nslookup unifi.services.home.lan` will return both 192.168.1.2 and 192.168.0.5

This behavior is not present when using the Filters > DNS Rewrites functionality.

#### Proposed solution
Perhaps by specifying a grouping-id to allow only specific rules to apply their records to the rewrite.

#### Alternatives considered
Or perhaps rewrite rules should only apply their results for the exact same rule match. With more specific rules be preferred over shorter ones.

#### Additional information
This is undesirable behaviour when the 2 IPs are completely different things, with one being a IP dedicated to a unifi network controller and the other being a general reverse proxy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.