AdguardTeam / AdguardTeam/AdGuardHome

Persistent client statistics don't take MAC addresses into account

Đang mở
#4,649 3 bình luận 3 reaction 1 người được giao Được @ainar-g nhận Xem trên GitHub
enhancement P3: Medium
Ngôn ngữ chính
TypeScript
Star
36.9k
Fork
2.5k
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

### Issue Details

* **Version of AdGuard Home server:**
* v0.107.7
* **How did you install AdGuard Home:**
* Home Assistant Add On
* **How did you setup DNS configuration:**
* AdGuardHome DHCP is Enabled (disabled on Linksys Velop router)
* **If it's a router or IoT, please write device model:**
* Home Assistant & AdGuardHome are running on RaspberryPi4 4GB
* **CPU architecture:**
* Raspberry Pi 4 4GB
* **Operating system and version:**
* HAOS (latest version)

### Expected Behavior
I have added Persistent Clients with both MAC Addresses and Names, and expect to see the activity mapped to these clients on the Dashboard and also on the Persistent Clients page. I also expect to see the "Runtime Clients" list shrink as I add these items to the "Persistent Clients" section.

### Actual Behavior
Instead, I only see the Dashboard show the client activity properly mapped. When I'm on the Client Settings page I don't see any "Requests" (activity) next to the Persistent Clients. I also don't see any reduction in the "Runtime Clients" list.

For example, I added my mobile phone to the Persistent Clients list with my phone's MAC Address. I see on the Dashboard that AdGuard has properly associated the IP Address and traffic with my MAC Address. However, on the Persistent Client's list there is no activity reflected on the right column under 'Requests'. And at the bottom under "Runtime Clients" I still see my mobile phone listed with activity showing up under 'Requests'.

What is odd is if I add my mobile phone's IP Address to the Persistent Client setting then the "Request" data will show up properly, but it will still not remove the device from the "Runtime Client" section.

It seems like the logic to map the values is not working properly on this "Client Settings" screen. Ideally the logic should mirror what is used on the Dashboard, and as devices get added to "Persistent Clients" they should be removed from the "Runtime Client" section.

### Screenshots

Screenshot:

### Additional Information

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.