AdevintaSpain / AdevintaSpain/Barista
Define parameter names convention and refactor
- Linguagem predominante
- Kotlin
- Estrelas
- 1.7k
- Forks
- 119
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
There are a lot of methods on the project that have the same parameter but using different names.
e.g, here are 3 different methods with the same parameter `@IdRes` using 3 different names:
`assertFocused(@IdRes resId: Int)`
`assertEndDrawerClosed(@IdRes id: Int)`
`assertRecyclerViewItemCount(@IdRes recyclerViewId: Int, expectedItemCount: Int)`
I think it will be a great idea to define a naming convention to keep the style while the project grows up
I know there's a lot of refactoring being done on the **barista2** branch, but I've already seen this on that branch
Guia de contribuição
Direção de pesquisa
Start by inventorying the three example methods and reviewing the refactoring already underway on the barista2 branch. Identify the project-wide parameter naming scope and confirm the convention with the existing discussion before changing methods. Done means the convention is agreed, applied consistently, and existing instrumentation tests still pass.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- android, kotlin
- Domínio
- testing
- Tipo de issue
- Refatoração
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Status de atividade
- Estagnada
- Clareza
- Precisa de esclarecimento
- Facilidade para iniciantes
- 25/100