ActivityWatch / ActivityWatch/aw-server-rust

DELETE endpoint to delete event(s)

Open
#60 7 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
315
Forks
96
Avg merge
2d 21h
Merged PRs (30d)
14

Description

My suggested API:
- Remove `DELETE /events/` endpoint
- Add `POST /events/delete/by_ids`
- Add `GET /events/delete/by_period?start=X&end=X`

Reasons why the old delete API is bad and should be replaced completely:
- The new "by_ids" endpoint makes it possible to remove multiple specific events in one go while the old API could only delete one event at a time.
- The old DELETE endpoint is also broken because both `/events/` and `/events/count` are in the same namespace

Things which need to be considered:
- Vacuuming the database

Resources:
- Discussion with @leoschwarz in aw-server-python PR https://github.com/ActivityWatch/aw-server/pull/57

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.