ActivityWatch / ActivityWatch/aw-server-rust

Category picking issues?

Aperta
#597 11 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
315
Fork
96
Merge medio
2g 21h
PR unite (30g)
14

Descrizione

It currently seems to base the priority of category application based on the depth and then position of a category.

https://github.com/ActivityWatch/aw-server-rust/blob/826efce375efde35baaa30aae5a498ed5e00f441/aw-transform/src/classify.rs#L116-L123

This means that in the scenario below, category 2b is picked over rule 1.

- Category 1 (matches)
- Category 2
- Category 2b (matches) ← picked

To avoid this, one needs to change it to:

- Category 1
- Category 1b (matches) ← picked
- Category 2
- Category 2b (matches)

This is inconvient and requires both exporting, manually editing the category JSON, and reimporting it, in addition to nesting category unnessarily.

I think it would be better to first prioritize the order and only override based on depth when it is a child of the previously picked category (e.g. overriding 2 with 2b).

This could be changed in the code above to only override it if the starting names match.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.