ActivityWatch / ActivityWatch/aw-server-rust

Category picking issues?

Open
#597 11 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
315
Forks
96
Avg merge
2d 21h
Merged PRs (30d)
14

Description

It currently seems to base the priority of category application based on the depth and then position of a category.

https://github.com/ActivityWatch/aw-server-rust/blob/826efce375efde35baaa30aae5a498ed5e00f441/aw-transform/src/classify.rs#L116-L123

This means that in the scenario below, category 2b is picked over rule 1.

- Category 1 (matches)
- Category 2
- Category 2b (matches) ← picked

To avoid this, one needs to change it to:

- Category 1
- Category 1b (matches) ← picked
- Category 2
- Category 2b (matches)

This is inconvient and requires both exporting, manually editing the category JSON, and reimporting it, in addition to nesting category unnessarily.

I think it would be better to first prioritize the order and only override based on depth when it is a child of the previously picked category (e.g. overriding 2 with 2b).

This could be changed in the code above to only override it if the starting names match.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.