AcevedoR / AcevedoR/rpg-maestro

fix: deploy is always run and hides docker error

Open
#19 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
0
Forks
0
Avg merge
16m
Merged PRs (30d)
7

Description

in the current CI, the docker-build and deploy phases are a bit hacked, two issues:
- the task will always run even if there is nothing to release from semantic-version phase
- if the command fails (docker build or push), il will be hidden and the phase will still be marked as success

ideas:
- use a plugin/custom-executor instead of an inlined command for docker-build and deploy
- possibly use a simpler lib to get the calculated semantic release version (https://github.com/absolute-version/commit-and-tag-version)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.