AcevedoR / AcevedoR/rpg-maestro

fix: deploy is always run and hides docker error

未关闭
#19 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
TypeScript
星标
0
派生
0
平均合并
16 分钟
30 天内合并 PR
7

描述

in the current CI, the docker-build and deploy phases are a bit hacked, two issues:
- the task will always run even if there is nothing to release from semantic-version phase
- if the command fails (docker build or push), il will be hidden and the phase will still be marked as success

ideas:
- use a plugin/custom-executor instead of an inlined command for docker-build and deploy
- possibly use a simpler lib to get the calculated semantic release version (https://github.com/absolute-version/commit-and-tag-version)

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。