AccelerateHS / AccelerateHS/accelerate

[BUG] Race between `clean` and `remoteFinalizer` for unmanaged buffers

Aberta
#563 0 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
Haskell
Estrelas
1k
Forks
135
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

**Description**
In `Data.Array.Accelerate.Array.Remote.Table`, there is a function called `insertUnmanaged` which I believe is necessary for handing off pre-existing CUDA buffers to Accelerate. There is an assumed invariant here, namely that the `remoteFinalizer` attached to a `Weak` reference is run before `deRefWeak` can return `Nothing` in `clean`. This is not actually always true, and `deRefWeak` can return `Nothing` before `remoteFinalizer` runs and thus `clean` will see a buffer in the table and it will be "unreferenced" and so it will invoke `freeStable` on it, thus you could accidentally free a buffer provided by `insertUnmanaged`.

**Steps to reproduce**
I have not seen this in the wild but this appears real from reading `Data.Array.Accelerate.Array.Remote.Table`. I have confirmed that this order-of-operations of `deRefWeak` and the finalizer logic are inconsistent in the way described above, with an example Haskell program.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.