AccelerateHS / AccelerateHS/accelerate-fft

Thread-unsafe cuFFT plan cache usage

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
11
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Fortunately plans are cached by `accelerate-fft` however there is only one plan per shape and data-type and no mutual exclusion for concurrent usage of that plan which poses a thread-safety issue when multiple separate threads try to use the same plan, assign it a corresponding CUDA stream, and then execute said plan. Execution could feasibly look like:
```
p = ... cached plan #1 ...
thread 1: FFT.setStream p s1
thread 2: FFT.setStream p s2
thread 1: FFT.execC2C p (fftMode mode) d_in d_out
thread 2: FFT.execC2C p (fftMode mode) d_in d_out
```

Solutions include:
1. Make redundant copies of cuFFT plans as concurrent demand is observed.
2. Enforce mutual exclusion on plans during `cuFFT` call.

The former is vastly preferred to the latter.

Additionally, the [cuFFT documentation](https://docs.nvidia.com/cuda/cufft/#thread-safety) makes clear that concurrent usage of plans is fundamentally thread-unsafe.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.