AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO
Build failure on GCC/MinGW (MXE): std::ifstream constructor mismatch with Platform::filenameToUTF()
- Lingua principale
- C++
- Stelle
- 2.1k
- Fork
- 503
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Description
OpenColorIO 2.5.1 fails to compile under GCC / MinGW-w64 (including MXE cross builds) due to inconsistent file path type handling in `Platform::filenameToUTF()` when used with `std::ifstream` in `FileTransform.cpp`.
The failure occurs when constructing a `std::ifstream` from the result of `Platform::filenameToUTF(filepath)`, where the returned type may vary between `std::string` and `std::wstring` depending on build configuration (`_WIN32 && UNICODE`).
This leads to template overload resolution failures under GCC/libstdc++ when a `std::wstring` is involved in `std::ifstream` construction.
Error observed (GCC / libstdc++)
```bash
error: no matching function for call to
std::basic_ifstream::basic_ifstream(const std::wstring, std::ios_base::openmode)
```
Affected code `src/OpenColorIO/transforms/FileTransform.cpp`:
```cpp
std::ifstream(Platform::filenameToUTF(filepath), mode)
```
Root cause
- `Platform::filenameToUTF()` is conditionally typed:
- `std::wstring` on _WIN32 && UNICODE
- `std::string` otherwise
- `std::ifstream` construction from `std::wstring` is not consistently supported across standard library implementations
- GCC/libstdc++ rejects this usage, while MSVC may accept it depending on STL implementation details
- This creates a portability issue in file I/O path handling
Impact
- Breaks MXE / MinGW-w64 cross compilation
- Causes divergence between MSVC and GCC builds
- Introduces non-portable file path handling in core I/O utilities
Suggested fix
Avoid passing platform-dependent string types directly into `std::ifstream` construction.
This is the C++17-compatible solution that worked:
```cpp
auto path = Platform::filenameToUTF(filepath);
return std::make_unique(path.c_str(), mode);
```
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Iniziare da src/OpenColorIO/transforms/FileTransform.cpp ed esaminare la costruzione di std::ifstream tramite Platform::filenameToUTF(filepath). Compilare OpenColorIO con GCC/MinGW-w64 o MXE per riprodurre il problema dell’overload std::wstring, quindi verificare che la gestione dei percorsi venga compilata e funzioni nelle configurazioni interessate.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- cpp
- Ambito
- build-system
- Tipo di issue
- Bug
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Tranquilla
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 78/100