AbsaOSS / AbsaOSS/hyperdrive

Identify component factories by identifier string

オープン
#99 コメント 0 件 リアクション 1 件 担当者 1 名 @kevinwallimann に割り当て済み GitHub で見る
enhancement
主要言語
Scala
スター
47
フォーク
14
PR マージ指標
30日以内にマージされた PR はありません

説明

**Description**
Currently, component factories are loaded in `ClassLoaderUtils` given their fully qualified classnames. The classname is passed by the configuration. (e.g. `component.writer`)

That means that components don't have the possibility to be refactored (renaming, moving to a different package) without introducing a breaking change which would require updating any existing configuration that uses that component.

**Tasks**
- Add a method `getIdentifier: String` to the interface `ComponentFactory`. `getClass.getName` may be used as a default value. (so this feature won't be a breaking change)
- Implementing components are responsible for providing a unique identifier. It's advisable to prefix the identifier with a human readable name, because it will be referenced in the configuration, logged, etc..
- Use `getIdentifier` to load the factory in `ClassLoaderUtils`. Currently, it loads the class directly given the class name. This approach doesn't work to efficiently load the factory by the identifier. With #83, component factories can be loaded using the Service Provider Interface (SPI), i.e. with `ServiceLoader`. All factories expose the `getIdentifier` method, that's how it can be found

**Other**
- The same identifier might be used by each component to prefix its configuration properties to avoid name clashes.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。