AbsaOSS / AbsaOSS/enceladus

Tidy up the data model

Đang mở
#647 0 bình luận 1 reaction 0 người được giao Xem trên GitHub
feature priority: undecided under discussion
Ngôn ngữ chính
Scala
Star
33
Fork
16
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

## Background
Our current data model has issues which when fixed could made maintaining the project much easier in the future.

## Feature
Tidy up the model as soon as possible so we won't need to do many complicated migrations between versions.

The list below is open for extension. Please, add things you would like to improve in out data model there.

## Proposed Solution
1. `OozieSchedule` object has fields that might be better placed elsewhere:
a. `mappingTablePattern` is better to be placed in `MappingTable`.
b. `rawFormat` is better to be placed in `Dataset`
2. If we put `rawFormat` into `Dataset` we might consider putting format-specific options there as well (rowtag, delimiter, etc.). Possibly as a String to String map so we would be able to support arbitrary format-specific options. For COBOL the number of options is so big that adding an attribute for each of them might be too much.
3. `parent` fields in entities has type of `MenasReference`. `MenasReference` has an optional `collection` parameter which should be None in the most imaginable cases. The exception is `attachment` collection. Possible solutions:
a. Remove `collection` from `MenasReference`.
b. Or (maybe better) reuse `MenasReference` in `Attachment`.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.