AbsaOSS / AbsaOSS/enceladus

VersionedModelController.create should yield Location header

未关闭
#1,611 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug priority: undecided
主要语言
Scala
星标
33
派生
16
PR 合并指标
30 天内没有已合并 PR

描述

## Describe the bug
All extending classes of `VersionedModelController` define a `/create` endpoint that persists an entity when called with POST. Correct response `201 Created` is returned. Customarily, this should be accompanied by the Location header with the URI pointing to the created item.

## To Reproduce
Steps to reproduce the behavior OR commands run:
1. Call e.g. `PUT /api/dataset/create` with a valid DS content.
2. Inspect the response.

## Expected behaviour
Location header to be generally present with all entity-creating calls.

## Additional context
An example of this is implemented in `PropertyDefinitionController.createDatasetProperty` : [[1](https://github.com/AbsaOSS/enceladus/blob/8d173718817572d25fc01449ef357092eda0205f/menas/src/main/scala/za/co/absa/enceladus/menas/controllers/PropertyDefinitionController.scala)]

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。