AbsaOSS / AbsaOSS/enceladus

Run has duplicate field - unique ID

未关闭
#1,102 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Menas priority: medium refactoring under discussion
主要语言
Scala
星标
33
派生
16
PR 合并指标
30 天内没有已合并 PR

描述

## Background
For historical reasons the `Run`'s `uniqueId` field is duplicated in `controlMeasure.runUniqueId` as it represents the contents of the `_INFO` file. The `_INFO` file references the run's unique ID, so a `conformance` job can find the correct `standardization job` to continue from, as `standardization + conformance` together constitute a single run.

## Feature
We should reduce this noise and only keep one field.

## Proposed Solution [Optional]
Solution Ideas
1. We can remove the top level field `uniqueId` OR
1. We can not include the `controlMeasure.runUniqueId` from the `_INFO` file
1. ~~We might just use the `Spark application ID`~~
1. We should make this field non-optional
1. Maybe we can just have a separate file (e.g. `_MENAS_RUN`), written by `Standardization` and read by `Conformance` to link the two spark jobs that doesn't need to be propagated to publish.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。