AbsaOSS / AbsaOSS/cps-shared-ui

Refactor color token structure: separate internal vs public tokens

Aperta
#542 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
9
Fork
6
Merge medio
23h 46m
PR unite (30g)
5

Descrizione

## Problem

The current color token architecture mixes internal palette values with public-facing semantic tokens, making it unclear which tokens are meant for internal theming and which should be consumed by host apps.

## Proposal

Establish a clear two-layer token structure:

1. **Internal palette files** — define raw color values per theme:
- `_colors-light.scss` — light theme palette
- `_colors-dark.scss` — dark theme palette

2. **Public token file** — `_colors.scss` exposes named semantic tokens that reference the internal palette. These are the only tokens consumer apps should use.

## Why

- Prevents host apps from depending on internal color values that may change between themes
- Makes it obvious which tokens are part of the public API
- Simplifies adding new themes in the future (just add a new palette file)
- Reduces confusion during code review and onboarding

## Out of scope

This issue is about restructuring and documenting the token layers — not changing any visual output. All resolved color values should remain the same.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.