AbandonTech / AbandonTech/abandonauth

Enforce schema in Callback URIs and use full URI in abandon auth UI

未关闭
#62 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
backend enhancement good first issue help wanted
主要语言
Python
星标
4
派生
2
平均合并
59 分钟
30 天内合并 PR
1

描述

## Summary

Callback URIs can be set to any arbitrary value, including relative paths or just nonsense. Currently the AbandonAuth UI for developer dashboards uses a [relative path](https://github.com/AbandonTech/abandonauth/blob/main/abandonauth/routers/ui.py#L40) for the callback URI. This should be changed to use the full URL in the specific environment. I.e in production we should be using `auth.abandontech.cloud/ui`, in dev it should use `localhost:{port}/ui` where port is the actual port the application is being locally deployed with.

## Acceptance Criteria

Callback URIs have validation either in the database, Pydantic models, or both that forces them to be in the form of a valid URI, therefore disallowing relative paths or random strings.
The AbandonAuth UI must also use the new, correct format for its own redirect to the AbandonAuth login page.

贡献指南

这个仓库没有索引到贡献指南

调研方向

The issue points to abandonauth/routers/ui.py line 40 where a relative path is used. Start by examining the Pydantic models and database schema for callback URI validation. Look for existing validation patterns in the codebase. The goal is to enforce a valid URI format and update the UI to use the full URL based on the environment (production vs. dev). Check configuration files for environment-specific settings.

由索引模型根据 Issue 内容生成。

评估

领域
authentication, backend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
65/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。