AOSSIE-Org / AOSSIE-Org/PictoPy

fix: date-based memories are misclassified as location memories

未關閉
#1,229 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
283
分支
679
平均合併
7 天 2 小時
30 天內合併 PR
3

描述

What happened?
Date-only memories are created with `center_lat = 0` and `center_lon = 0` in the backend, but the frontend checks `center_lat == null || center_lon == null` to determine whether a memory is date-based.

As a result, date-based memories can be treated as location memories.

Why this matters
- incorrect badge shown on memory cards
- incorrect title formatting for date-based memories
- incorrect location/date counts and filtering in the Memories page

Relevant code
- backend/app/utils/memory_clustering.py
- frontend/src/components/Memories/MemoryCard.tsx
- frontend/src/components/Memories/MemoryDetail.tsx
- frontend/src/components/Memories/MemoriesPage.tsx

Expected behavior
Date-based memories should be consistently identified either by:
- returning `null` for `center_lat` / `center_lon` from the backend, or
- using the explicit memory `type` field in the frontend instead of inferring from coordinates.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。