AOSSIE-Org / AOSSIE-Org/OrgExplorer

[BUG]: runAudit silently swallows rate limit errors — governance page shows incomplete data without any warning

未關閉
#81 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
JavaScript
星號
34
分支
92
平均合併
8 天 7 小時
30 天內合併 PR
12

描述

### Bug Description

When GitHub API rate limits are hit during runAudit(), the error is swallowed by fetchIssues(), which catches all exceptions and returns an empty array.

As a result:

1. runAudit() continues execution.
2. Governance/Analytics pages display partial audit results.
3. Users receive no indication that data is incomplete.
4. The behavior differs from explore(), which correctly surfaces rate-limit errors.

Expected Behavior

If a GitHub rate-limit error (HTTP 403) occurs during an audit:

1. The audit should stop or be marked as incomplete.
2. The user should receive a clear notification/error message.
3. Results should not appear as a successful complete audit when data is missing.

Actual Behavior

fetchIssues() returns [] for all errors, including rate-limit failures, causing the audit to proceed silently with incomplete data

### Steps to Reproduce

Prerequisites: No PAT configured (unauthenticated = 60 req/hr limit)

Step 1 — Exhaust your rate limit
Open the app without a PAT set in Settings. Search for 2–3 large organizations. Each explore() call fetches org metadata + up to 500 repos + contributors for top 10 repos per org. This burns through the 60 req/hr unauthenticated limit quickly.

You can verify your limit is near exhaustion by checking the Rate Limit Banner (appears when remaining ≤ 20% of limit) or going to Settings and checking the quota display.

Step 2 — Navigate to Governance page
After the explore completes, go to Governance → Run Audit. runAudit() will begin fetching issues for the top 15 repos in batches of 5.

Step 3 — Observe the silent failure
While the audit is running (or after it finishes), if the rate limit hits mid-batch:

1. The govLoading spinner disappears normally — as if the audit completed successfully
2. The Governance page shows stat cards with counts (e.g., "Dead Issues: 0", "Zombie PRs: 0")
3. The Analytics page shows "No trend data" or flat charts
4. No error message is shown anywhere
5. No banner or warning indicates that some repos returned no data

### Logs and Screenshots

Image

### Environment Details

OS : Windows 11
Browser : Brave
Node.js: 22.18.0

### Impact

Medium - Feature works but has issues

### Code of Conduct

- [x] I have joined the [Discord server](https://discord.gg/hjUhu33uAn) and will post updates there
- [x] I have searched existing issues to avoid duplicates

貢獻指南

開啟貢獻指南

研究方向

Trace runAudit() through fetchIssues() and compare its error handling with explore(), then inspect the Governance and Analytics page states. Reproduce the issue with an exhausted unauthenticated GitHub API limit; done means a rate-limit failure stops or marks the audit incomplete and shows a clear warning instead of presenting partial results as complete.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
github, javascript
領域
analytics, api
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
冷清
描述清晰度
基本清楚
新手友好度
56/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。