AOSSIE-Org / AOSSIE-Org/OrgExplorer

[BUG]: computeHealthScore returns NaN when open_issues_count is missing

Aperta Adatta ai principianti
#211 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
JavaScript
Stelle
34
Fork
92
Merge medio
8g 7h
PR unite (30g)
12

Descrizione

### Bug Description

computeHealthScore() in src/services/analytics.js computes issueHealth with an
unguarded repo.open_issues_count:

const total = (repo.open_issues_count || 0) + 10
const issueHealth = Math.max(0, 100 - (repo.open_issues_count / total) * 100)

The `total` line defends against a missing open_issues_count with `|| 0`, but the
issueHealth line uses the bare `repo.open_issues_count`. When the field is absent,
`undefined / total` is NaN, so issueHealth is NaN and the whole score collapses to
NaN — which then renders in the UI and corrupts any sorting/averaging built on it.

GitHub can omit open_issues_count, and the inconsistency (guarded on one line,
unguarded on the very next) makes this a clear oversight rather than intended behavior.

### Steps to Reproduce

1. Open src/services/analytics.js.
2. Call computeHealthScore with a repo that has a valid pushed_at but no open_issues_count:

```js
import { computeHealthScore } from './src/services/analytics.js'

computeHealthScore({ pushed_at: new Date().toISOString() }, 2) // -> NaN
```

3. Observe: the score is NaN, with no error thrown.

### Logs and Screenshots

Reproduced locally on main (Node v22.17.0):

```
computeHealthScore({ pushed_at: , /* no open_issues_count */ }, 2): NaN
computeHealthScore({}, 3): NaN
```

### Environment Details

- OS: Windows (MINGW64 / Git Bash)
- Browser: Chrome
- Node.js: 22.17.0
- Branch: main
- Affected function: computeHealthScore (src/services/analytics.js, issueHealth line)
- Note: the sibling `total` line already guards this field with `|| 0`; the fix is to
apply the same guard on the issueHealth line.

### Impact

Medium - Feature works but has issues

### Code of Conduct

- [x] I have joined the [Discord server](https://discord.gg/hjUhu33uAn) and will post updates there
- [x] I have searched existing issues to avoid duplicates

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Open src/services/analytics.js and inspect computeHealthScore, especially the issueHealth calculation beside the guarded total calculation. Reproduce the missing open_issues_count case described in the issue, then verify that the returned score is numeric rather than NaN and that the existing valid-repository behavior remains intact.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript
Ambito
analytics
Tipo di issue
Bug
Difficoltà
1/5
Tempo stimato
1-3 ore
Stato di attività
Attiva
Chiarezza
Specificata chiaramente
Idoneità per principianti
88/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.