AOSSIE-Org / AOSSIE-Org/OpenVerifiableLLM

[FEATURE]: Complete BPETokenizer and BaseTokenizer-Add encode, decode and load to BaseTokenizer and BPETokenizer

未关闭
#52 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
Python
星标
18
派生
31
平均合并
1 分钟
30 天内合并 PR
2

描述


## Summary

This issue proposes adding encode(), decode(), and load() to BaseTokenizer as abstract methods and implementing them fully in BPETokenizer. This completes the BPE tokenizer
contract and ensures all future tokenizer implementations
are required to support these core operations.


## Background

PR #17 introduced `BaseTokenizer` as an abstract interface and `BPETokenizer` as its first implementation.

The current `BaseTokenizer` defines:
```
train() ✅ defined
get_vocab_path() ✅ defined
get_merges_path() ✅ defined

encode() ❌ not defined
decode() ❌ not defined
load() ❌ not defined
```

Since encode(), decode() and load() are not part of the abstract interface, subclasses have no obligation to
implement them. This breaks the tokenizer contract and leaves BPETokenizer only half complete.

---

## Problems in Current Implementation

### 1. BaseTokenizer does not enforce encode/decode/load

### 2. BPETokenizer cannot encode or decode

### 3. No way to reload BPETokenizer from disk

### 4. No input validation in BPETokenizer.train()

---

## Proposed Changes

### `openverifiablellm/tokenizer/base.py`

**Add three abstract methods:**

### `openverifiablellm/tokenizer/bpe_tokenizer.py`

**Implement encode():**

**Implement decode():**

**Implement load():**

**Harden train():**

### `tests/test_bpe.py` ← new file

With this PR:

- BaseTokenizer enforces full workflow
- BPETokenizer is fully usable
- encode → decode works
- Pipeline can progress to model training

---


## Scope

This is a change touching only:
- `base.py`
- `bpe_tokenizer.py`
- `tests/test_bpe.py`

No overlap with any existing open PRs.
No dependency on any other issue.

---

## Related

- PR #17 — feat: deterministic tokenizer training and config hashing

### Additional Context

_No response_

### Code of Conduct

- [x] I have joined the [Discord server](https://discord.gg/hjUhu33uAn) and will post updates there
- [x] I have searched existing issues to avoid duplicates

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。