AOSSIE-Org / AOSSIE-Org/EduAid

Critical: Race condition in /getTranscript causes potential data leaks

Aperta
#420 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
171
Fork
425
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

**Problem**
The `/getTranscript` endpoint currently uses `glob.glob` and `max(key=os.path.getctime)` to identify the downloaded subtitle file.

**The Logic Flaw**
This assumes that the file currently being processed is *always* the newest file in the `subtitles/` directory.
In a concurrent environment (multiple users), if User B's download finishes slightly after User A's download, User A's request thread will incorrectly identify User B's file as the "latest" and return the wrong transcript.

**Impact**
1. **Data Leak:** Users receive transcripts for videos they did not request.
2. **Crash:** If the "latest" file is deleted by another thread before it can be read, the server throws a `FileNotFoundError`.

**Proposed Solution**
Since the filename is deterministic (`subtitles/{video_id}.vtt`), we should explicitly construct the file path using the `video_id` instead of searching the directory.
I am working on a fix for this and will submit a PR shortly.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.