AOSSIE-Org / AOSSIE-Org/DebateAI

[BUG]: No Validation room type when creating a debate room

Aberta Para iniciantes
#492 2 comentários 0 reações 0 responsáveis Ver no GitHub
bug
Linguagem predominante
TypeScript
Estrelas
84
Forks
198
Merge médio
2d 19h
PRs com merge (30d)
30

Descrição

### Bug Description

he POST /rooms endpoint accepts any non-empty value for the room type. Although the supported room types are public, private, and invite, unsupported values such as "banana" are accepted and stored successfully.
This allows invalid room data to enter the application and may cause unexpected behavior in room browsing, filtering, matchmaking, and access-control logic.

The backend should validate the supplied room type against the supported values and return 400 Bad Request when the value is invalid. This fix only requires backend validation and does not require a database schema change.

### Steps to Reproduce

1. Start the DebateAI backend server.

2. Sign in and obtain a valid access token.

3. Open Git Bash and define the API URL and token:
api="http://localhost:1313"
token="PASTE_ACCESS_TOKEN_HERE"

4. Send a room-creation request with an unsupported type:
curl.exe -i -X POST "$api/rooms" \
-H "Authorization: Bearer $token" \
-H "Content-Type: application/json" \
--data '{"type":"banana"}'

5. Observe that the backend returns 200 OK and creates the room:
HTTP/1.1 200 OK
{
"id": "882822",
"type": "banana"
}

Actual Behavior
The backend accepts the unsupported room type and creates a room with "type": "banana".

Expected Behavior
The backend should reject unsupported room types and return:
400 Bad Request
{
"error": "Invalid room type"
}

### Logs and Screenshots

Image

Image

Image

### Environment Details

_No response_

### Impact

High - Major feature is broken

### Code of Conduct

- [x] I have joined the [Discord server](https://discord.gg/hjUhu33uAn) and will post updates there
- [x] I have searched existing issues to avoid duplicates

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Direção de pesquisa

Start by running the DebateAI backend and reproducing the issue with the provided POST /rooms curl request. Find the backend handler for POST /rooms and add validation so only public, private, and invite are accepted. Done means an unsupported type like banana returns 400 Bad Request with the stated error and no room is created.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
typescript
Domínio
api, backend
Tipo de issue
Bug
Dificuldade
2/5
Tempo estimado
1-3 horas
Status de atividade
Ativa
Clareza
Claramente especificada
Facilidade para iniciantes
74/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.