AOSSIE-Org / AOSSIE-Org/DebateAI

Concede message shown incorrectly + pre-existing ESLint errors in OnlineDebateRoom.tsx

Aperta
#344 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
84
Fork
198
Merge medio
2g 19h
PR unite (30g)
30

Descrizione

When a user concedes the debate, both users receive "You win!" due to the WebSocket concede event being broadcast to all participants without checking who was the sender. Additionally, the file had 13 pre-existing ESLint errors including unused variables, empty catch blocks, and implicit any types.

Screenshot:
Image

Steps to Reproduce:
Open a debate room in two browsers
One user clicks Concede
Both users incorrectly see "You win! "

Expected Behavior: Only the opponent should see "You win!". The conceding user should see "You have conceded."

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.